I usually regret not wearing bike or at least tri shorts to spin class. I generally wear them with a regular workout t-shirt and bike shoes.

My gym has one super-bikey instructor who wears a club bike jersey when he teaches. Some of the guys (haven't seen women do this) who go to his class also wear bike kits. The total overkill is good for a giggle.