Long shorts for me. I had a pair of short ones, mid-thigh, and they cut into all my loose jiggly-bits and made me feel uncomfortable and gave me annoying elastic lines. The longer ones go down to where my legs actually get muscular so no lines from the elastic!