What do they know?
I think it's down to personal preference. Some people like the extra coverage of long shorts (sun protection!), some like the muscle support, and some people get "sausage leg" and such from mid-thigh length shorts.
I do like mid-thigh length shorts myself, even though the grippers dig in a bit and look weird. But then, I don't like long sleeve shirts...