Personally, I think cycling attire should be chosen based on riding location and conditions as much as possible. There are times when a black jersey will be more visible than a white one. When I used to ride in NC - there were a couple of winter rides we did where the roads were clear, but the fields had snow on them and the sun was super bright. A white clad rider would have totally disappeared and black would have offered more contrast.

On the other hand, wearing black at night is just asking for trouble.

I would opt to not wear orange when commuting home into the sunset (I kept my turquoise for those rides) and I don't wear my lime green jersey when riding in the country in the spring as it's virtually the same color as the fields/trees as they start to bloom.

That said, I actually noticed yesterday in our typical winter gloom that NOTHING stood out on cyclists (I was in a car) as well as hi-vis yellow. It made itself glaringly apparent in every single case (daylight conditions).