I'm 5'2" with a 28" inseam and use 170mm cranks on my road and mtn bikes. My slightly older Terry bike has 165mm cranks. Both are fine, but I chose 170s when I custom built my Aegis Swift and Bike Friday as I felt they'd give me more leverage on hills (and hopefully not kill my knees), and on my Aegis I wanted a compact double, which didn't come in a smaller length than 170. They seem to agree with me fine, even though all the charts say I should ride a 165mm or shorter crank based on my inseam.
Emily
Emily
2011 Jamis Dakar XC "Toto" - Selle Italia Ldy Gel Flow
2007 Trek Pilot 5.0 WSD "Gloria" - Selle Italia Diva Gel Flow
2004 Bike Friday Petite Pocket Crusoe - Selle Italia Diva Gel Flow