My favorite shorts:

Performance Ultra
Terry T-shorts

This keeping in mind that I have never tried any of the more popular shorts on this board: Pearl Izumi, Shebeest, Sugoi, etc. But the above work well for me, and I got all mine on sale.

Emily