I'm 5'4" with a 30" inseam. I'm on an XS but it is a TCR so slightly different geometry. I was too stretched out on the small. I LOVE my giant; it is a comp 1. Just make sure you're comfortable. Not squished, not overly stretched etc. Test ride both the S and XS